[VPD-312] Set Pivot and Fallback Oracle for ETH, USDC, USDT and SolvBTC #641
Conversation
| { | ||
| target: bscmainnet.BINANCE_ORACLE, | ||
| signature: "setMaxStalePeriod(string,uint256)", | ||
| params: ["ETH", HEARTBEAT_100_SECONDS], |
There was a problem hiding this comment.
curious, usually how do u decide stale period ? Is it always a little bit buffer more than oracle provider's (this time binance) heartbeat ?
vips/vip-571/bscmainnet.ts
Outdated
| ], | ||
| [ | ||
| SolvBTC, | ||
| [bscmainnet.CHAINLINK_ORACLE, bscmainnet.REDSTONE_ORACLE, bscmainnet.BINANCE_ORACLE], |
There was a problem hiding this comment.
Let's remove solvBTC and handle it separately for the following reason:
Given chainlink only supports solvBTC/BTC quote instead of usd based quote, and our existing chainlink oracle configuration for solvBTC is pointing to btc, it doesn't make sense to pretend set all 3 for solvBTC
There was a problem hiding this comment.
This is the chainlink feed (https://data.chain.link/feeds/bsc/mainnet/btc-usd) we are using for SolvBTC. It gives BTC price in USD. We are using BTC and SolvBTC is 1:1 ratio.
There was a problem hiding this comment.
yeah, that's exactly what i am trying to say
fred-venus
force-pushed
the
feat/vpd-312
branch
from
4cdfe64 to
0a3a3de
Compare
fred-venus
force-pushed
the
feat/vpd-312
branch
from
0a3a3de to
d6a0951
Compare
Description
Resolves VEN