-
Notifications
You must be signed in to change notification settings - Fork 3
[VPD-281]: [Mainnet] BNB HardFork - Fermi Upgrade #654
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
|
||
| export const ACM = "0x4788629abc6cfca10f9f969efdeaa1cf70c23555"; | ||
| export const VBNB_ADMIN = "0x9A7890534d9d91d473F28cB97962d176e2B65f1d"; | ||
| export const CORE_POOL_RATE_MODEL_SETTER = "0x8504EF43463c1edC9897182c6e17C0ad47B9Ad31"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please verify this contract
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Verified on Sourcify.eth
|
|
||
| export const NEW_VAI_IMPLEMENTATION = "0xFD754b21F5dbbf6eb282911Cc0112cbF88190767"; | ||
| export const NEW_PLP_IMPLEMENTATION = "0x46BED43b29D73835fF075bBa1A0002A1eD1E4de8"; | ||
| export const NEW_PRIME_IMPLEMENTATION = "0x1a6660059E61e88402bD34FC96C2332c5EeAF195"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please verify NEW_VAI_IMPLEMENTATION, NEW_PLP_IMPLEMENTATION and NEW_PRIME_IMPLEMENTATION contracts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All are already verified on Sourcify.eth
| export const PLP_PROXY = "0x23c4F844ffDdC6161174eB32c770D4D8C07833F2"; | ||
| export const VAI_UNITROLLER = "0x004065D34C6b18cE4370ced1CeBDE94865DbFAFE"; | ||
|
|
||
| export const NEW_VAI_IMPLEMENTATION = "0xFD754b21F5dbbf6eb282911Cc0112cbF88190767"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
where is the pr to deploy those 3 ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also redeployment of VenusLens ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| { | ||
| target: COMPTROLLER, | ||
| signature: "_setVenusSpeeds(address[],uint256[],uint256[])", | ||
| params: [[XVS_MARKET], [XVS_MARKET_SUPPLY_REWARD_PER_BLOCK], [0]], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
have we checked that if other markets except XVS_MARKET has non-zero reward ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, all of them are zero.
|
|
||
| // Block reward calculations adjusted for new block time (0.45s vs 0.75s) | ||
| // Formula: old_rate * 100 / 167 (equivalent to dividing by 1.67) | ||
| // Block time ratio: 0.75s / 0.45s = 1.67 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the prime reward are no longer correct since we have a monthly update. Try to use a latest block num when check in simulation
This VIP upgrades the implementations of contracts, rewards emission speeds and enables the checkpoint interest rate models for the core pool deployed in VenusProtocol/venus-protocol#655 to accommodate for BNB chain Fermi upgrade.