Skip to content

Potential fixes for 2 code quality findings #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
daedaevibin merged 2 commits into from
Jun 11, 2026
Merged

Potential fixes for 2 code quality findings #34

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f3a47ca
Apply suggested fix to tools/migrate_presentation_strings.py from Cop…
daedaevibin Jun 11, 2026
a4059e4
Apply suggested fix to tools/migrate_presentation_strings.py from Cop…
daedaevibin Jun 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions tools/migrate_presentation_strings.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,8 @@
('contentDescription = "Play/Pause"', 'contentDescription = stringResource(R.string.mashup_cd_play_pause)'),
('contentDescription = "Song Cover"', 'contentDescription = stringResource(R.string.cd_song_cover)'),
('Text("Delete")', 'Text(stringResource(R.string.delete_action))'),
# Legacy literals found in some source files; keep these explicit Spanish matches
# so the migration reliably rewrites them to localized string resources.
('contentDescription = "Limpiar"', 'contentDescription = stringResource(R.string.cd_clear_search_query)'),
('contentDescription = "Buscar"', 'contentDescription = stringResource(R.string.cd_search_icon)'),
]
Expand All @@ -56,11 +58,9 @@ def insert_imports(text: str) -> str:
insert_at = i + 1
to_add = []
if needs_string_resource(text):
if STRING_IMPORT not in text:
to_add.append(STRING_IMPORT + "\n")
to_add.append(STRING_IMPORT + "\n")
if needs_r_import(text):
if R_IMPORT not in text:
to_add.append(R_IMPORT + "\n")
to_add.append(R_IMPORT + "\n")
if not to_add:
return text
return "".join(lines[:insert_at] + to_add + lines[insert_at:])
Expand Down
Loading