Resolve the same tool synchronously and asynchronously - #800
Merged
Conversation
Launch asked TryFindByExtension and LaunchAsync asks TryFindForInputFilePath. The two differ: only the second can see a text file convention, since the first is handed an extension and a convention matches on the whole path. So a file matched by a convention rather than by its extension opened a diff tool through LaunchAsync and reported NoDiffToolFound through Launch. Kill used the extension lookup too, so it then logged that it could not find a tool for a pair LaunchAsync had opened - leaving the tool on screen for a test that had started passing, which is the one thing Kill exists to prevent. Both now go through TryFindForInputFilePath. Kill's log message changes with it, since "Extension not found" was already describing a lookup it no longer does. The test pins the gap between the two lookups rather than driving DiffRunner. A convention matched file can only resolve to the first text tool installed on the machine - a fake one cannot be registered for it - so a behavioural test would launch the developer's real diff tool. The change itself is which of the two calls these make, and is verified by reading.
This was referenced Aug 26, 2026
This was referenced Aug 27, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Launch asked TryFindByExtension and LaunchAsync asks TryFindForInputFilePath.
The two differ: only the second can see a text file convention, since the first
is handed an extension and a convention matches on the whole path.
So a file matched by a convention rather than by its extension opened a diff
tool through LaunchAsync and reported NoDiffToolFound through Launch. Kill used
the extension lookup too, so it then logged that it could not find a tool for a
pair LaunchAsync had opened - leaving the tool on screen for a test that had
started passing, which is the one thing Kill exists to prevent.
Both now go through TryFindForInputFilePath. Kill's log message changes with it,
since "Extension not found" was already describing a lookup it no longer does.
The test pins the gap between the two lookups rather than driving DiffRunner. A
convention matched file can only resolve to the first text tool installed on the
machine - a fake one cannot be registered for it - so a behavioural test would
launch the developer's real diff tool. The change itself is which of the two
calls these make, and is verified by reading.