Do not spend an instance slot on a relaunch - #802
Merged
Conversation
InnerLaunch killed the tool already showing a pair and then asked MaxInstance whether it was allowed to launch. Once the per process counter was spent the answer was no - so a re-failing test closed its own diff window and opened nothing in its place, reporting TooManyRunningDiffTools with the move sent as processId null. The count is meant to bound how many tools are open at once, and a replacement does not raise that number. KillIfNotMdi now reports whether it actually closed something, and a launch that is replacing skips the check. An MDI tool closes nothing, so it is not replacing and still counts. MaxInstance gains an internal ResetCount, because the counter is process wide and never reset, so a limit means nothing definite in a test otherwise. Worth knowing for anyone else writing one of these: MaxInstance reads DiffEngine_MaxInstances before the app domain value, and that variable persists per user - it is set to 5 on this machine, which is why the test sets it per process rather than calling MaxInstancesToLaunch alone. My first version did call it alone, and silently ran with a limit of 5.
This was referenced Aug 26, 2026
This was referenced Aug 27, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
InnerLaunch killed the tool already showing a pair and then asked MaxInstance
whether it was allowed to launch. Once the per process counter was spent the
answer was no - so a re-failing test closed its own diff window and opened
nothing in its place, reporting TooManyRunningDiffTools with the move sent as
processId null.
The count is meant to bound how many tools are open at once, and a replacement
does not raise that number. KillIfNotMdi now reports whether it actually closed
something, and a launch that is replacing skips the check. An MDI tool closes
nothing, so it is not replacing and still counts.
MaxInstance gains an internal ResetCount, because the counter is process wide
and never reset, so a limit means nothing definite in a test otherwise.
Worth knowing for anyone else writing one of these: MaxInstance reads
DiffEngine_MaxInstances before the app domain value, and that variable persists
per user - it is set to 5 on this machine, which is why the test sets it per
process rather than calling MaxInstancesToLaunch alone. My first version did
call it alone, and silently ran with a limit of 5.