Tidy two pieces of definition data - #811
Merged
Merged
Conversation
BeyondCompare listed .tbz2 and .iso twice each. Harmless to matching, since the set is a set, but the generated docs repeated them and a reader has no way to tell a deliberate duplicate from an oversight. Neovim hardcoded C:\Program Files\Neovim\bin. Written as a literal it gets no expansion, so it misses ProgramW6432 and the x86 variant that %ProgramFiles% resolves, and it assumes Windows is installed on C: - which is not something the other definitions assume.
This was referenced Aug 26, 2026
This was referenced Aug 27, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BeyondCompare listed .tbz2 and .iso twice each. Harmless to matching, since the
set is a set, but the generated docs repeated them and a reader has no way to
tell a deliberate duplicate from an oversight.
Neovim hardcoded C:\Program Files\Neovim\bin. Written as a literal it gets no
expansion, so it misses ProgramW6432 and the x86 variant that %ProgramFiles%
resolves, and it assumes Windows is installed on C: - which is not something the
other definitions assume.