Reveal the directory when the file is not there yet - #836
Merged
Conversation
Revealing a pending move points at the target, which for a snapshot being written for the first time does not exist. Nothing checked, so explorer was asked to select a path that is not there - which opens the default folder, Documents, nothing to do with the review - and open -R errored. Linux happened to be fine, having only ever opened the directory. The directory is shown instead, which is where the file is about to be written, and a path whose directory is missing too opens nothing. The decision is its own function so it can be tested: everything around it starts a process.
This was referenced Aug 26, 2026
This was referenced Aug 27, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Revealing a pending move points at the target, which for a snapshot being written
for the first time does not exist. Nothing checked, so explorer was asked to select
a path that is not there - which opens the default folder, Documents, nothing to do
with the review - and open -R errored. Linux happened to be fine, having only ever
opened the directory.
The directory is shown instead, which is where the file is about to be written, and
a path whose directory is missing too opens nothing.
The decision is its own function so it can be tested: everything around it starts a
process.