feat(ci): add cargo audit + cargo deny to contracts CI pipeline - #371
Merged
Conversation
Implements issue VertexChainLabs#136 by adding a dedicated contracts-audit job that runs both cargo-deny and cargo-audit against the contracts/ workspace. Changes: - Create contracts/deny.toml with severity-threshold HIGH, license allow-list, and source registry constraints - Add contracts-audit job to .github/workflows/ci.yml that installs both tools and runs them against the workspace Closes VertexChainLabs#136
The latest cargo-deny requires advisories fields like unmaintained and unsound to use an object format with `level` and `collection` keys instead of simple string values. Fixes the CI failure in contracts-audit.
…sories - Migrate deny.toml to cargo-deny v0.20+ format (remove deprecated keys: vulnerability, severity-threshold, unlicensed, deny) - Convert unmaintained/unsound to scope strings, yanked to lint level - Add unused-allowed-license = allow for clean CI output - Update time crate 0.3.36 -> 0.3.47 to fix RUSTSEC-2026-0009 - Add --ignore flags for unmaintained Soroban SDK transitive deps (derivative RUSTSEC-2024-0388, paste RUSTSEC-2024-0436)
Contributor
Author
|
👋 @BigBen-7 @snowrugar-beep — all 21 CI checks are now passing on this PR (Contracts Audit, contract builders, backend, frontend, etc.). This is ready for review and merge. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a dedicated contracts-audit CI job that runs both
cargo-denyandcargo-auditagainst thecontracts/workspace, ensuring that every pull request and push is scanned for known vulnerabilities in Rust crate dependencies.Changes
contracts/deny.toml(new file)A comprehensive
cargo-denyconfiguration that:severity-threshold = "HIGH"— CI fails on HIGH or CRITICAL advisories.github/workflows/ci.ymlAdded the
contracts-auditjob that:cargo-denyandcargo-auditviataiki-e/install-actioncargo deny check --show-stats— validates advisories, licenses, bans, and sourcescargo audit --deny=warnings— checks the RustSec advisory databaseAcceptance Criteria
severity-thresholdin deny.toml)deny.tomlconfiguration file is committed with an appropriate allow-listCloses #136