Skip to content

declare requests as a dependency #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

erral
Copy link

@erral erral commented Jul 1, 2022

requests is declared as a dependency in the requirements.txt file but not in the setup.py file. If the dependency is not declared in the setup.py file, requests is not installed when installing the package from pip, and it breaks:

erral@lindari:/tmp$ virtualenv itzuli-test
created virtual environment CPython3.8.10.final.0-64 in 119ms
  creator CPython3Posix(dest=/tmp/itzuli-test, clear=False, global=False)
  seeder FromAppData(download=False, pip=bundle, setuptools=bundle, wheel=bundle, via=copy, app_data_dir=/home/erral/.local/share/virtualenv)
    added seed packages: pip==22.1.2, setuptools==62.2.0, wheel==0.37.1
  activators BashActivator,CShellActivator,FishActivator,PowerShellActivator,PythonActivator,XonshActivator
erral@lindari:/tmp$ cd itzuli-test/
erral@lindari:/tmp/itzuli-test$ ./bin/pip install Itzuli
Collecting Itzuli
  Using cached Itzuli-1.1.0-py3-none-any.whl (14 kB)
Installing collected packages: Itzuli
Successfully installed Itzuli-1.1.0
erral@lindari:/tmp/itzuli-test$ ./bin/python
Python 3.8.10 (default, Mar 15 2022, 12:22:08) 
[GCC 9.4.0] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> import Itzuli
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/tmp/itzuli-test/lib/python3.8/site-packages/Itzuli/__init__.py", line 1, in <module>
    from Itzuli.Api import Itzuli
  File "/tmp/itzuli-test/lib/python3.8/site-packages/Itzuli/Api.py", line 4, in <module>
    import requests
ModuleNotFoundError: No module named 'requests'


@erral
Copy link
Author

erral commented Feb 22, 2023

ping

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant