Add REF nodes for lazy allocation, and extract closed sub-exprs into new definitions#15
Open
Boscop wants to merge 21 commits into
Open
Add REF nodes for lazy allocation, and extract closed sub-exprs into new definitions#15Boscop wants to merge 21 commits into
Boscop wants to merge 21 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the
REFnodes for lazy allocation ofdefsub-nets.It also implements extraction of sub-terms into new definitions when possible.
E.g.
gets pre-processed to:
but only when
definition_book.extract_closed_subterms();is called (like it is inmain.rs).Currently,
mainis printing the before and after:When a
REFnode is interacted with, it gets substituted with its term's net, and then the normal rewriting continues.