PLT-1360 - Configure Pronto/Simplecov code coverage in rlovelett-ffmpeg #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduced the 'coveralls_reborn' gem to the project and set it up within the test suite to track test coverage. Updated the README to include the Coveralls coverage status badge, ensuring visibility into the project's code coverage metrics. This change assists in maintaining and improving code quality. # Please note any issue or ticket numbers related to this change if applicable.
Add Coveralls Integration
Add autogenerated code for lcov
spaetzel
requested review from
todd-m-kemp and
JoshGalantai-Vidyard
and removed request for
a team
| - name: Install Deps | ||
| run: | | ||
| apt update && apt install cmake -y |
There was a problem hiding this comment.
Do we need to install cmake for rubocop to run? 🤔
There was a problem hiding this comment.
cmake is for rugged - which is used by Pronto/Undercover to perform git operations
| rainbow (>= 2.1, < 4.0) | ||
| rugged (>= 0.27, < 1.7) | ||
| unicode-display_width (2.5.0) | ||
| uri (0.13.0) | ||
|
|
||
| PLATFORMS | ||
| ruby | ||
|
|
||
| DEPENDENCIES |
There was a problem hiding this comment.
Oof, that's a lot of new deps just for code coverage 😰
|
Need to turn on read & write permissions for actions in the repo. Asked @masterful to flip this on |
todd-m-kemp
previously approved these changes
Feb 9, 2024
Always run pronto steps
Add write access to discussions in CI workflow
More permissions
Move bundle install
This reverts commit 0b6f319.
added 2 commits
February 12, 2024 12:05
masterful
approved these changes
Feb 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First implementation of Pronto code coverage, adding to
rlovelett-ffmpegfirst since it's open source and could be cloned outside the org for quick iteration.Action now adds inline PR comments for both Code coverage and Rubocop problems.
Github Copilot Description
This pull request primarily focuses on enhancing the continuous integration (CI) pipeline and improving code quality checks. The changes include updating the GitHub Actions workflow to trigger on both push and pull request events, adding permissions to the GitHub Actions workflow, updating the actions used in the workflow, and adding new dependencies to the Gemfile. Additionally, the SimpleCov and Undercover gems have been added for better code coverage tracking.
GitHub Actions workflow updates:
.github/workflows/ci.yaml: The workflow now triggers on both push and pull request events, and additional permissions have been added for the GitHub Actions workflow. The actions used in the workflow have been updated to their latest versions, and additional dependencies have been added to the installation step. A new step has been added to setup and run Pronto for code quality checks during pull request events.Dependency additions:
Gemfile: New dependencies have been added to the Gemfile, including the RuboCop Performance and RuboCop Rake gems for enhanced code quality checks, the Faraday Retry gem for retrying network requests, and the Pronto and Pronto RuboCop gems for running code quality checks. The Undercover gem has been added for tracking untested code sections, and the Rugged, SimpleCov, and SimpleCov-Lcov gems have been added to the test group for better code coverage tracking.Code coverage tracking:
spec/spec_helper.rb: The SimpleCov and SimpleCov-Lcov gems have been required and configured for code coverage tracking. The Undercover gem has also been required for tracking untested code sections.