Minor

VisetDev · Jan 23, 2024 · 80f50e7 · 80f50e7
1 parent 7f65991
commit 80f50e7
Show file tree

Hide file tree

Showing 8 changed files with 606 additions and 598 deletions.
diff --git a/packages/collection_editor/src/ui/collection_editor/CollectionDetailsForm.tsx b/packages/collection_editor/src/ui/collection_editor/CollectionDetailsForm.tsx
@@ -1,5 +1,5 @@
 import React, { useEffect, useState } from "react";
-import { EntityCollection, getIconForView, SearchIcons, singular, toSnakeCase, } from "@firecms/core";
+import { EntityCollection, getIconForView, SearchIconsView, singular, toSnakeCase, } from "@firecms/core";
 import {
     Autocomplete,
     AutocompleteItem,
@@ -351,8 +351,8 @@ export function CollectionDetailsForm({
                     fullWidth
                 >
                     <div className={"p-4 overflow-auto min-h-[200px]"}>
-                        <SearchIcons selectedIcon={values.icon}
-                                     onIconSelected={(icon: string) => {
+                        <SearchIconsView selectedIcon={values.icon}
+                                         onIconSelected={(icon: string) => {
                                          setIconDialogOpen(false);
                                          setFieldValue("icon", icon);
                                      }}/>

diff --git a/packages/firecms_core/src/components/SearchIconsView.tsx b/packages/firecms_core/src/components/SearchIconsView.tsx
@@ -1,6 +1,7 @@
-import * as React from "react";
+import React from "react";
+
 import { coolIconKeys, debounce, Icon, IconButton, iconKeys, SearchBar, Tooltip } from "@firecms/ui";
-import { iconsSearch, icon_synonyms } from "../util";
+import { icon_synonyms, iconsSearch } from "../util";
 
 const UPDATE_SEARCH_INDEX_WAIT_MS = 220;
 
@@ -14,10 +15,13 @@ if (process.env.NODE_ENV !== "production") {
 
 export interface SearchIconsProps {
     selectedIcon?: string;
-    onIconSelected: (icon: string) => void;
+    onIconSelected?: (icon: string) => void;
 }
 
-export function SearchIcons({ selectedIcon = "", onIconSelected }: SearchIconsProps) {
+export function SearchIconsView({
+                                selectedIcon = "",
+                                onIconSelected
+                            }: SearchIconsProps) {
     const [keys, setKeys] = React.useState<string[] | null>(null);
     const [query, setQuery] = React.useState<string>("");
 
@@ -27,7 +31,7 @@ export function SearchIcons({ selectedIcon = "", onIconSelected }: SearchIconsPr
                 setKeys(null);
             } else {
                 const searchResult = iconsSearch.search(value);
-                setKeys(searchResult.map((e:any) => e.key));
+                setKeys(searchResult.map((e: any) => e.key));
             }
         }, UPDATE_SEARCH_INDEX_WAIT_MS), []
     );
@@ -57,10 +61,10 @@ export function SearchIcons({ selectedIcon = "", onIconSelected }: SearchIconsPr
                             <IconButton
                                 shape={"square"}
                                 toggled={selectedIcon === icon}
-                                onClick={() => onIconSelected(icon)}
+                                onClick={onIconSelected ? () => onIconSelected(icon) : undefined}
                                 className="box-content m-1"
                             >
-                                <Icon iconKey={icon} size={24} />
+                                <Icon iconKey={icon} size={24}/>
                             </IconButton>
                         </Tooltip>
                     );

diff --git a/packages/firecms_core/src/form/field_bindings/MarkdownFieldBinding.tsx b/packages/firecms_core/src/form/field_bindings/MarkdownFieldBinding.tsx
diff --git a/packages/ui/src/components/common/SelectInputLabel.tsx b/packages/ui/src/components/common/SelectInputLabel.tsx
@@ -1,3 +1,4 @@
+import React from "react";
 import { cn } from "../../util";
 
 export function SelectInputLabel({ children, error }: { children: React.ReactNode, error?: boolean }) {

diff --git a/website/docs/icons/icons.mdx b/website/docs/icons/icons.mdx
@@ -3,6 +3,7 @@ id: icons
 title: Icons
 ---
 
-import { SearchIcons } from "@firecms/core";
 
-<SearchIcons/>
+import { DocsIconsView } from "../../src/DocsIconsView";
+
+<DocsIconsView/>
diff --git a/website/docusaurus.config.js b/website/docusaurus.config.js
@@ -37,6 +37,7 @@ module.exports = {
                         resolve: {
                             alias: {
                                 "firecms": path.resolve(__dirname, "../packages/firecms/src"),
+                                "@firecms/core": path.resolve(__dirname, "../packages/firecms_core/src"),
                                 "@firecms/ui": path.resolve(__dirname, "../packages/ui/src"),
                             },
                         },

diff --git a/website/sidebars.js b/website/sidebars.js
@@ -95,6 +95,7 @@ module.exports = {
                 "recipes/documents_as_subcollections"
             ]
         },
+        "icons/icons",
         {
             "type": "category",
             "label": "Components",

diff --git a/website/src/DocsIconsView.tsx b/website/src/DocsIconsView.tsx
@@ -2,6 +2,6 @@ import React from "react";
 
 import { SearchIconsView } from "@firecms/core";
 
-export default function DocsIconsView() {
+export function DocsIconsView() {
     return <SearchIconsView/>;
 }