Skip to content

Fix portable launcher deps#223

Merged
t3nka merged 1 commit into
VisoMasterFusion:devfrom
t3nka:fix-portable-launcher-deps
May 8, 2026
Merged

Fix portable launcher deps#223
t3nka merged 1 commit into
VisoMasterFusion:devfrom
t3nka:fix-portable-launcher-deps

Conversation

@t3nka
Copy link
Copy Markdown
Contributor

@t3nka t3nka commented May 8, 2026

Summary

Fixes the portable launcher's dependency update action to use supported uv configuration and properly report failures.

Changes

  • Replaces unsupported uv pip install CLI arguments with equivalent environment variables:
    • --timeoutUV_HTTP_TIMEOUT
    • --retriesUV_HTTP_RETRIES
    • --concurrent-downloadsUV_CONCURRENT_DOWNLOADS
  • Preserves user-provided uv environment variable overrides
  • Runs dependency install with check=True to catch failures
  • Prevents checksum state from updating on install failure
  • Shows error dialog to user on dependency update failure
  • Adds focused tests for uv command formatting, environment handling, success path, and failure path

Testing

.\.venv\Scripts\python.exe -m pre_commit run --files app\ui\launcher\core.py app\ui\launcher\launcher_window.py tests\unit\ui\test_launcher_dependency_update.py
.\.venv\Scripts\python.exe -m pytest tests\unit\ui\test_launcher_dependency_update.py -q

@t3nka t3nka added the patch Bug fixes, documentation, refactors, dependency updates label May 8, 2026
@t3nka t3nka merged commit c1d35d6 into VisoMasterFusion:dev May 8, 2026
@t3nka t3nka deleted the fix-portable-launcher-deps branch May 10, 2026 02:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

patch Bug fixes, documentation, refactors, dependency updates

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant