Video encoding separation to new file#248
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR refactors the FFmpeg encoding pipeline by extracting subprocess management into a new dedicated module (
video_encoding.py), reducing code duplication by ~500 lines and improving testability and maintainability.🎯 Key Changes
1. New Module:
FFmpegEncoderClass (video_utils/video_encoding.py)start_process(),write_frame(),close_process(),is_running()2. New Module:
FFmpegPostProcessorClass (Stateless utilities)extract_audio_segments()– Extracts per-segment audio with validationconcatenate_audio_segments()– Merges audio using FFmpeg concat demuxerwrite_video_only_output()– Fallback video-only muxing when audio processing failsconcatenate_segments_video_only()– Segment-mode video concatenation fallbackvalidate_audio_file()– Validates audio integrity before processing3. Refactored
video_processor.pyself.encoder.start_process()self.encoder.write_frame()andself.encoder.is_running()self.encoder.close_process()handles all subprocess terminationcreate_ffmpeg_subprocess()method (functionality moved toFFmpegEncoder)FFmpegPostProcessor)4. Enhanced Face Expression Processing (
frame_edits.py,faceutil.py)5. UI/UX Improvements
6. TensorRT Cache Cleanup (
models_processor.py)_clean_tensorrt_cache()method safely removes corrupted engine/timing files✅ Benefits