Conversation
sidrasali
reviewed
Aug 7, 2025
| // Symbols | ||
| object PLUS : TokenType() | ||
|
|
||
| object MINUS : TokenType() |
Contributor
There was a problem hiding this comment.
I think we can remove this line
sidrasali
approved these changes
Aug 7, 2025
sidrasali
reviewed
Aug 8, 2025
| TokenType.NEGATION to 45, | ||
| TokenType.MULTIPLY to 50, | ||
| TokenType.DIVIDE to 50, | ||
| TokenType.REMAINDER to 50 |
Contributor
There was a problem hiding this comment.
can you explain these numbers?
Contributor
Author
There was a problem hiding this comment.
Those numbers are based on the book, you can check page 95.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We added the feature of Unary Expression, where we support negation (-) and complement (~). Then we added Binary Expression where we support binary operations (-,+,*,%). The features were reflected on both lexer and parser. We built the parser based on left-associative expressions with precedence climbing. Furthermore, we added Tests for parser.