fix: use VirtualSize instead of SizeOfRawData for Windows PE .bun section#7
Closed
taocihei wants to merge 1 commit into
Closed
fix: use VirtualSize instead of SizeOfRawData for Windows PE .bun section#7taocihei wants to merge 1 commit into
taocihei wants to merge 1 commit into
Conversation
…tion On Windows PE builds, SizeOfRawData includes file-alignment padding, causing the Bun trailer validation to read trailing NUL bytes and fail. Prioritizes VirtualSize to read actual data boundary.
Owner
|
Thanks for the fix! The same change landed via #17 (commit 663433e on 2026-04-29) — your branch is now in conflict because both branches modified the same line. Current main has |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
markdown
Problem
vpcc patchfails on Windows PE builds with:fail [bun-inplace] Bun trailer invalid - format change
plain
Root Cause
On Windows PE builds,
.bunsection has:VirtualSize= 131,532,925 bytes (actual data)SizeOfRawData= 131,533,312 bytes (+387 bytes file-alignment padding)Current code uses
rsize or vsize, causingbun_hito land inside trailing NUL padding. Trailer validation reads\x00bytes instead of the real trailer and fails.Fix
Change section size resolution to prioritize
VirtualSize: