Open
Conversation
ELDiablO59152
force-pushed
the
fix_broken_x509_form
branch
from
583b07b to
a0a8891
Compare
frikilax
reviewed
Sep 10, 2025
| from system.pki.models import (ALPN_CHOICES, BROWSER_CHOICES, PROTOCOL_CHOICES, TLSProfile, X509Certificate, | ||
| VERIFY_CHOICES) | ||
| CharField, ChoiceField) | ||
| from system.pki.models import (TLSProfile, X509Certificate, ALPN_CHOICES, BROWSER_CHOICES, PROTOCOL_CHOICES, |
Comment on lines
+71
to
+72
| if cleaned_data.get('type') == "internal" and not cleaned_data.get('cn'): | ||
| self.add_error('cn', "This field is required if 'type' is 'internal'") |
Member
There was a problem hiding this comment.
Suggested change
| if cleaned_data.get('type') == "internal" and not cleaned_data.get('cn'): | |
| self.add_error('cn', "This field is required if 'type' is 'internal'") | |
| if cleaned_data.get('type') != "external" and not cleaned_data.get('cn'): | |
| self.add_error('cn', "This field is required") |
Comment on lines
+146
to
+150
| CERTIFICATE_TYPE_CHOICES = ( | ||
| ('internal', "Self-Signed Vulture Certificate"), | ||
| ('letsencrypt', "Let's Encrypt Certificate"), | ||
| ('external', "External certificate") | ||
| ) |
Member
|
When saving an "external certificate", the form cannot be validated and no errors are shown (presumably the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed