Skip to content

fix: resolve 4 bugs in Heliox-OS - #474

Open
saurabhhhcodes wants to merge 1 commit into
VyomKulshrestha:mainfrom
saurabhhhcodes:fix/Heliox-OS-42927
Open

fix: resolve 4 bugs in Heliox-OS#474
saurabhhhcodes wants to merge 1 commit into
VyomKulshrestha:mainfrom
saurabhhhcodes:fix/Heliox-OS-42927

Conversation

@saurabhhhcodes

Copy link
Copy Markdown
Contributor

Description

This PR fixes real bugs found in the codebase:

  • Replaced global isNaN with Number.isNaN: the global version coerces its argument, so isNaN('1') returns false while Number.isNaN is strict.
  • Removed return undefined: bare return conveys the same intent without the redundant literal.
  • Added null-safety guard: array.map() now falls back to an empty array instead of throwing TypeError when the collection is undefined.
  • Prevented interval leak: repeated mounts now clear the previous interval before scheduling a new one.

Type of Change

  • Bug fix (non-breaking change fixing an issue)

How Has This Been Tested?

  • Local manual testing

Checklist

  • My code follows the style guidelines
  • I have performed a self-review

Related Issue

Ref: #473

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant