chore: test, a11y, healthcheck, and docs improvements - #294
Merged
Conversation
- Add Jest + jsdom test setup for dashboard/app.js - Cover getDemoInvoices, formatTimestamp, getStatusBadge - Cover renderTable, renderSummary, render filtering/sorting - Cover fetchInvoices error handling and fallback to demo data - 21 tests covering data-fetching and rendering logic
- Add sr-only labels for search input and status filter in index.html - Add skip-to-content links on both dashboard pages - Add scope='col', aria-sort, and aria-label to invoice table - Add role='button', tabindex='0', aria-expanded, aria-controls to ABI explorer collapsible sections - Add keyboard support (Enter/Space) for ABI explorer toggles - Add focus-visible styles for interactive elements - Fix contrast: empty-state text #9ca3af → #6b7280
- Add start_period to Redis healthcheck for reliable readiness detection - Add mongodb service_healthy condition to backend depends_on
- Explain automatic merge mechanism of Compose override files - Note common values developers edit (env vars, ports, volume mounts) - Show how to inspect effective config with docker-compose config
chore: test, a11y, healthcheck, and docs improvements
|
@micmusjnr20 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Four improvements across testing, accessibility, Docker healthchecks, and documentation. See individual commit messages for details.
Closes #277
Closes #278
Closes #279
Closes #280