chore: solana tx #5673
Merged
chore: solana tx #5673
+84
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakubuid
reviewed
Mar 5, 2025
| @@ -106,3 +109,35 @@ export async function isValidEip1271Signature( | |||
| function generateJsonRpcId() { | |||
| return Date.now() + Math.floor(Math.random() * 1000); | |||
| } | |||
|
|
|||
| export function extractSolanaTransactionId(solanaTransaction: string): string { | |||
| const binary = atob(solanaTransaction); | |||
There was a problem hiding this comment.
what's atob?
in Kotlin i'm trying to decode base64 if fails base58
There was a problem hiding this comment.
atob decodes base64 string. I added a bit extra validation just in case to avoid handling dummy data.
For example, atob throws if the string is not valid base64 encoding, and the validation after that will filer base64 encoded non transaction values
There was a problem hiding this comment.
got it
phantom docs says that these signed transactions can be base58 encoded but our solana rpc docs say that they can be base64
i think we should add decoding for both
jakubuid
approved these changes
Mar 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added custom parsing for
solana_signAllTransactionsType of change
How has this been tested?
tests
Checklist
Additional Information (Optional)
Please include any additional information that may be useful for the reviewer.