Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: replaced lodash with es-toolkit #5696

Merged
merged 6 commits into from
Mar 12, 2025
Merged

Conversation

ganchoradkov
Copy link
Member

Description

Replaced lodash with es-toolkit based on #5629 due to the conflicts in the main PR.

bundle size reduction after the change

Type of change

  • Chore (non-breaking change that addresses non-functional tasks, maintenance, or code quality improvements)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Draft PR (breaking/non-breaking change which needs more work for having a proper functionality [Mark this PR as ready to review only when completely ready])
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How has this been tested?

ci tests

Checklist

  • I have performed a self-review of my own code
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

Additional Information (Optional)

Please include any additional information that may be useful for the reviewer.

@ganchoradkov ganchoradkov requested review from Copilot and Cali93 March 12, 2025 08:19

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors the codebase to replace lodash's merge utility with that provided by es-toolkit, leading to a slight reduction in bundle size.

  • Replaced the lodash/merge import with es-toolkit/compat's merge.
  • Achieved a minor bundle size reduction by removing the lodash dependency.
@arein arein added the accepted label Mar 12, 2025
Copy link

socket-security bot commented Mar 12, 2025

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/[email protected] None 0 2.77 MB toss-build-bot

🚮 Removed packages: npm/@types/[email protected]

View full report↗︎

@ganchoradkov ganchoradkov merged commit fa90651 into v2.0 Mar 12, 2025
10 checks passed
@ganchoradkov ganchoradkov deleted the refactor/replace-lodash branch March 12, 2025 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants