Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Add achievement system #209

Merged
merged 6 commits into from
Oct 29, 2023
Merged

✨ Add achievement system #209

merged 6 commits into from
Oct 29, 2023

Conversation

shmily7829
Copy link
Contributor

Why need this change? / Root cause:

  • add feature achievement-system

Changes made:

Test Scope / Change impact:

  • achievement-system

@shmily7829 shmily7829 changed the title :real achievement-system ✨ achievement-system Oct 22, 2023
Copy link
Collaborator

@wow890209 wow890209 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review down.

@shmily7829 shmily7829 changed the title ✨ achievement-system ✨ Add achievement system Oct 22, 2023
@m1a2st m1a2st force-pushed the feature/achievement branch 5 times, most recently from a289f67 to 58c12ff Compare October 24, 2023 13:47
@Wally5077 Wally5077 force-pushed the feature/achievement branch from 7cde2d9 to 1b8a05a Compare October 24, 2023 17:49
Copy link
Collaborator

@Wally5077 Wally5077 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Wally5077 Wally5077 force-pushed the feature/achievement branch 2 times, most recently from 71e997f to 00f377f Compare October 24, 2023 18:03
@Wally5077 Wally5077 force-pushed the feature/achievement branch from 00f377f to 2bcca1e Compare October 24, 2023 18:07
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

76.3% 76.3% Coverage
0.0% 0.0% Duplication

Copy link
Collaborator

@wow890209 wow890209 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@m1a2st m1a2st merged commit 31d3f27 into main Oct 29, 2023
@m1a2st m1a2st deleted the feature/achievement branch October 29, 2023 05:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants