feat(contract): add setup_application_milestones function#381
Merged
Akshola00 merged 2 commits intoWeb3Novalabs:mainfrom Apr 27, 2026
Merged
feat(contract): add setup_application_milestones function#381Akshola00 merged 2 commits intoWeb3Novalabs:mainfrom
Akshola00 merged 2 commits intoWeb3Novalabs:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds setup_application_milestones to the Soroban contract, allowing sponsors or trusted schools to allocate pool funds into time-based milestones for a student's graduation journey.
Changes
Introduced Milestone contracttype struct (amount: u128, unlock_time: u64)
Introduced DataKey enum for type-safe persistent storage
Implemented setup_application_milestones(env, pool_id, student, milestones) with full invariant enforcement
Added get_milestones read accessor
Added 9 tests covering all happy-path and revert scenarios
Invariants enforced
Pool must exist and be open
Pool creator (validator) must authorise the call via require_auth()
Milestones array must be non-empty
Sum of milestone amounts must equal the pool goal exactly
Cannot overwrite an already-active milestone schedule for the same student
Testing
All 15 tests pass (6 existing + 9 new). Build and formatter clean.
closes #327