Fix visibility change and loss of full activity events #595
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change fixes the steps for handling visibility change and loss of full activity to find the global object for the Document which experienced the event and from there identify the Bluetooth object for which we need to take action. This introduces the concept of an "associated Bluetooth", similar to an "associated Document" and adds a "Bluetooth task source" which is now used whenever queuing a task. Fixed #593.
|
Oh no, this change never got merged and now I need to rebase and reconcile it with #643. |
…into relevant_global
|
This is a follow-up to my last PR which further cleans up the spec language and fixes the referenced issue. |
jyasskin
reviewed
Feb 10, 2025
jyasskin
approved these changes
Feb 10, 2025
github-actions bot
added a commit
that referenced
this pull request
Feb 10, 2025
SHA: 030375d Reason: push, by reillyeon Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot
added a commit
that referenced
this pull request
Feb 10, 2025
SHA: 030375d Reason: push, by reillyeon Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot
added a commit
that referenced
this pull request
Feb 10, 2025
SHA: 030375d Reason: push, by reillyeon Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot
added a commit
that referenced
this pull request
Feb 10, 2025
SHA: 030375d Reason: push, by reillyeon Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes the steps for handling visibility change and loss of full activity to find the global object for the Document which experienced the event and from there identify the Bluetooth object for which we need to take action.
This introduces the concept of an "associated Bluetooth", similar to an "associated Document" and adds a "Bluetooth task source" which is now used whenever queuing a task.
Fixed #593.
Preview | Diff