fixing charset problem #1274
Open
fixing charset problem #1274
+24
−25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arcuri82
requested changes
Jul 9, 2025
| @@ -201,7 +201,7 @@ class RestTestCaseWriter : HttpWsTestCaseWriter { | |||
| override fun handleVerbEndpoint(baseUrlOfSut: String, _call: HttpWsAction, lines: Lines) { | |||
|
|
|||
| val call = _call as RestCallAction | |||
| val verb = call.verb.name.lowercase(Locale.getDefault()) | |||
| val verb = call.verb.name.lowercase(Locale.ENGLISH) | |||
There was a problem hiding this comment.
looks like several places use Locale.getDefault(). can you fix all of the occurrencies in this PR? also, might be good to specify a setDefault in the main entry point (ie Main) to avoid possible issues in future
arcuri82
requested changes
Jul 21, 2025
There was a problem hiding this comment.
hi @omursahin i think we should make sure we use Locale.ENGLISH and not getDefault() for a few reasons:
- setting locale as you did now in the core would not apply to driver (eg SutController)
- changing default locale on driver might impact the SUT
- future unit test cases might fail if main is not called first
we can still have a Locale.setDefault(Locale.ENGLISH) in Main as safety net, but I think all other cases should be explicit in Locale.ENGLISH
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.