Different content type support #1279
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arcuri82
requested changes
Jul 22, 2025
| @@ -132,22 +132,23 @@ public static AuthenticationDto getForJsonTokenBearer( | |||
| String payload, | |||
| String extractFromField){ | |||
|
|
|||
| return getForJsonToken(dtoName, postEndpoint, payload, extractFromField, "Bearer "); | |||
| return getForJsonToken(dtoName, postEndpoint, payload, extractFromField, "Bearer ", "application/json"); | |||
| } | |||
|
|
|||
| public static AuthenticationDto getForJsonToken( | |||
There was a problem hiding this comment.
this is a breaking change. need to be careful about this utility functions that are used in the drivers. in this case, to avoid breaking current caller, should keep original signature of method, which call this new method with default parameter, ie, something like:
public static AuthenticationDto getForJsonToken(
String dtoName,
String postEndpoint,
String payload,
String extractFromField,
String headerPrefix
){
return getForJsonToken(dtoName, postEndpoint, ... , "application/json")
arcuri82
approved these changes
Jul 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.