New Workload: validatorjs regexp heavy workload #147
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for webkit-jetstream-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
kmiller68
reviewed
Aug 19, 2025
|
Hmm, this seems like it spends about 1/4 to 1/3 of the time in utf8ToBytes, which seems higher than I'd like |
|
Oops, I've profiled before including more tests that skewed the results massively. |
|
Looks like the CLI versions are failing. |
|
assertion conditions are hard :) flipped it the correct way now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This runs the validatorjs test suite and stress-tests various regexp and some dynamic property lookups.
Given that we've lowered the priority of regex-dna by grouping the sunspider workloads, it might make sense to add another regexp workload again.