Skip to content

Fix incomplete session description - #22

Merged
MiguelsPizza merged 1 commit into
mainfrom
claude/fix-incomplete-description-011CUweLPgWCjCU9MeS8h7nQ
Nov 9, 2025
Merged

Fix incomplete session description#22
MiguelsPizza merged 1 commit into
mainfrom
claude/fix-incomplete-description-011CUweLPgWCjCU9MeS8h7nQ

Conversation

@MiguelsPizza

Copy link
Copy Markdown
Contributor

When using the Cloudflare Vite plugin, the dev script should use 'vite dev' instead of 'wrangler dev'. This allows the Vite plugin to integrate the dev server with the Workers runtime, serving both the React app AND the worker endpoints together.

Using 'wrangler dev' directly only runs the worker code, which only handles /sse, /sse/*, and /mcp routes, returning 404 for the React app at /.

Changes:

  • Update dev script from 'wrangler dev --port 8888' to 'vite dev'
  • Add dev:wrangler script as fallback for direct wrangler usage
  • The vanilla template is unaffected (it uses wrangler assets correctly)

Fixes issue where templates return 404 for root path in development.

Description

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Refactoring (no functional changes)
  • Performance improvement
  • Test addition/improvement

Related Issues

Fixes #
Related to #

Changes Made

  • Change 1
  • Change 2
  • Change 3

Testing

Test Commands Run

pnpm typecheck  # ✓ Passed
pnpm lint       # ✓ Passed
pnpm build      # ✓ Passed
pnpm test       # ✓ Passed - E2E tests run locally

Manual Testing

  • Tested in development mode (pnpm dev)
  • Tested production build (pnpm build && preview)
  • Tested on mobile/tablet (if UI changes)
  • Tested WebMCP integration (if applicable)
  • Tested MCP tool execution (if applicable)

Screenshots

Checklist

  • My code follows the style guidelines in CONTRIBUTING.md
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings or errors
  • I have added tests that prove my fix is effective or that my feature works
  • I have run E2E tests locally (pnpm test) and they pass
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published

Breaking Changes

None

Additional Notes

When using the Cloudflare Vite plugin, the dev script should use 'vite dev'
instead of 'wrangler dev'. This allows the Vite plugin to integrate the dev
server with the Workers runtime, serving both the React app AND the worker
endpoints together.

Using 'wrangler dev' directly only runs the worker code, which only handles
/sse, /sse/*, and /mcp routes, returning 404 for the React app at /.

Changes:
- Update dev script from 'wrangler dev --port 8888' to 'vite dev'
- Add dev:wrangler script as fallback for direct wrangler usage
- The vanilla template is unaffected (it uses wrangler assets correctly)

Fixes issue where templates return 404 for root path in development.
@cloudflare-workers-and-pages

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Updated (UTC)
✅ Deployment successful!
View logs
mcp-ui-with-webmcp-my-mcp-server 1262e1e Nov 09 2025, 04:01 AM

@MiguelsPizza
MiguelsPizza merged commit c6c6cf1 into main Nov 9, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants