Fix multisig registry VCP Tevery escrow bug by explicitly processing leader/initiator signature, mirroring kli multisig join initiator evt replay#426
Closed
kentbull wants to merge 2 commits intoWebOfTrust:mainfrom
Conversation
kli multisig join initiator evt replaykli multisig join initiator evt replay
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #426 +/- ##
==========================================
- Coverage 87.74% 87.69% -0.05%
==========================================
Files 26 27 +1
Lines 5808 5844 +36
==========================================
+ Hits 5096 5125 +29
- Misses 712 719 +7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
kentbull
commented
Mar 24, 2026
| source={}, | ||
| status=registry["regk"], | ||
| ) | ||
| agent_deeds = doist.enter(doers=[agent]) |
Collaborator
Author
There was a problem hiding this comment.
Moved code into the try/except so that the finally block would close out the Doist and release ports once done.
Collaborator
Author
|
I was incorrect and misunderstood a comment in KERIpy's Multiplexor.add. Closing the PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For consistent
kli multisig joinlike behavior and to fixTevery ANC unescrow#403 errors KERIA needs an explicit replay of multisig events from leaders or other group members. This explicit replay ensures that multisig operation joiners will pull in the multisig leader's anchor of events like multisig registry inception (/multisig/vcp) and multisig issuance (/multisig/iss)events, among others.Currently KERIA does not explicitly replay this and only accidentally properly stores a multisig anchor in multisig group members of 3 or more members.
This PR fix intermittent errors regarding processing interaction events and their anchors by closing a replay gap between the KLI and KERIA's multisig processing. KLI uses the
JoinDoerinjoin.pyand theMultiplexor.KERIA’s multisig follower approval path (like
kli multisig join) is less explicit about event replay from multisig leaders/other members than KLIJoinDoerfor/multisig/vcp/multisig/iss/multisig/revand/multisig/rpyIn KLI, the multisig follower
anc.raw + pathed["anc"]), andjoin.py).In KERIA, follower approval :
IdentifierResourceEnd.interact(...), which processes the locally submittedixnand localsigs,"group"is present, queues that local event intoagent.groups(keriaaiding.py).GroupRequesterthen starts counselor tracking for that local group event (keriaagenting.py),paths["anc"],That makes the current behavior indirect and timing-sensitive:
"group"processing and laterMultiplexor.add(...)duplicate parsing can sometimes still get to the correct multisig state,ANC Missing escrowed anchor/ stalled TEL multisig state convergence (keripygrouping.py).Essentials of this PR
Current state:
anc = bytearray(aserder.raw) + pathed["anc"]self.psr.parseOne(ims=bytes(anc))ixnsigs"group"metadatapaths["anc"]"group"handling is real, but narrower than KLI replay:IdentifierResourceEnd.interact(...)queues the local group eventGroupRequesterstarts counselor tracking for that local eventMultiplexor.add(...)can sometimes rescue multisig state, but only in the case when a later equivalent peer EXN arrives after local approval, which only happens in multisig groups of 3 or more.Solution:
The gap is not “multisig follower approval is absent,” but KERIA does not make the KLI-style stored-attachment initiator signature replay step explicit in follower approval routes.
/multisig/vcp/multisig/iss/multisig/revand/multisig/rpymirroring KLI semantics.