Skip to content

[2.46][GST][MSE] Skip playback state update while EOS #1568

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: wpe-2.46
Choose a base branch
from
Open

[2.46][GST][MSE] Skip playback state update while EOS #1568

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions Source/WebCore/platform/graphics/gstreamer/mse/MediaPlayerPrivateGStreamerMSE.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -477,6 +477,15 @@ void MediaPlayerPrivateGStreamerMSE::updateStates()
}
}

if (m_isEndReached) {
// m_isEndReached always makes HTMLMediaElement think playback is paused,
// despite the actual pipeline state. Notifying playback state change
// here would sync HTMLMediaElement state to paused while the pipeline
// could be in PLAYING state. That could effectively pause the pipeline
// without any pause request from the user.
shouldUpdatePlaybackState = false;
}

if (!shouldUpdatePlaybackState)
return;

Expand Down