[퍼블리싱] 디테일 페이지 #18
Open
[퍼블리싱] 디테일 페이지 #18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
모바일 뷰에서 width 조정이 필요해보입니다! |
Contributor
|
Contributor
|
이건 사실 이전 PR때 확인했어야 하는 부분인데 제가 미처 확인하지 못했네요
가운데 정렬이 안 되어있는 것 같습니다. |
minsoo-web
requested changes
Mar 19, 2022
Contributor
minsoo-web
left a comment
minsoo-web
left a comment
There was a problem hiding this comment.
리뷰 모두 남겼습니다~! 고생하셨어요! 수정 완료되면 노티 부탁드립니다.
src/components/Detail/MusicAbout/MusicCommentList/MusicCommentList.tsx
Outdated
Show resolved
Hide resolved
Member
Author
|
희윤님께 음악 카테고리 부분 최대 개수 3개로 전달 받아서 따로 레이아웃은 처리해야할 부분 없을꺼 같고, |
Member
Author
|
999 오버시 K,M 사용하도록 3자리까지 디자인 수정하였다고 하셨습니다 |
Member
Author
|
999 오버시 K,M 변환 작업은 따로 빼야할꺼 같은데 어디에 빼는게 좋을까요? |
Contributor
utils 폴더하나 만들구 getCounts 같은 함수 하나 만들어서 카운트 개수에 따라서 다르게 보여지게끔 처리하면 될 것 같습니다 |
minsoo-web
requested changes
Apr 3, 2022
Contributor
minsoo-web
left a comment
minsoo-web
left a comment
There was a problem hiding this comment.
몇 가지 리뷰 사항이 있습니다! 반영해서 작업해주세요
src/components/Detail/MusicAbout/MusicCommentList/MusicComment/MusicComment.tsx
Show resolved
Hide resolved
src/components/Detail/MusicAbout/MusicCommentList/MusicComment/MusicComment.tsx
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
디테일 페이지 퍼블리싱입니다.
Profile부분 PR 닫아주시면 반응형까지 작업해서 말씀드리겠습니다 :)