fix: embed IANA timezone database to fix startup failure on Windows#1434
Open
octo-patch wants to merge 1 commit intoWei-Shaw:mainfrom
Open
fix: embed IANA timezone database to fix startup failure on Windows#1434octo-patch wants to merge 1 commit intoWei-Shaw:mainfrom
octo-patch wants to merge 1 commit intoWei-Shaw:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1398
Problem
On platforms without a system-level timezone database (notably Windows),
time.LoadLocation()fails withunknown time zone Asia/Shanghai, causing the server to exit at startup:Go's
time.LoadLocationrelies on the OS timezone data (/usr/share/zoneinfoon Linux/macOS), which is not available on Windows.Solution
Add a blank import of
time/tzdatainbackend/cmd/server/main.go. This embeds the complete IANA timezone database directly into the compiled binary (~450 KB overhead), making alltime.LoadLocationcalls work on every platform without requiring OS timezone data.Testing
timezone.Init()ininternal/pkg/timezone/timezone.gothroughinternal/repository/ent.go