Add New Port Mappings for Helm chart#352
Merged
peixian merged 6 commits intoWhatsApp:mainfrom Feb 20, 2025
Merged
Conversation
facebook-github-bot
added
the
CLA Signed
peixian
force-pushed
the
peixian/add-external-loadbalancer
branch
2 times, most recently
from
549a74f to
4ce8417
Compare
peixian
force-pushed
the
peixian/add-external-loadbalancer
branch
from
4ce8417 to
515e365
Compare
eozturk1
reviewed
Feb 19, 2025
| # http_proxy_port: 8080 | ||
| # https_proxy_port: 8443 | ||
| # jabber_proxy_port: 8222 | ||
| # media_proxy_port: 7777 |
Contributor
There was a problem hiding this comment.
We need this one as well?
Member
Author
There was a problem hiding this comment.
No, these are left as examples for other users
eozturk1
reviewed
Feb 19, 2025
| {{- if .Values.service.media_proxy_port }} | ||
| - port: {{ .Values.service.media_proxy_port }} | ||
| targetPort: 7777 | ||
| protocl: TCP |
Contributor
There was a problem hiding this comment.
Hmm.. typo? How is YAML passing?
peixian
force-pushed
the
peixian/add-external-loadbalancer
branch
from
25486ea to
b4fe2a4
Compare
eozturk1
reviewed
Feb 19, 2025
| {{- if .Values.service.media_port }} | ||
| - port: {{ .Values.service.media_port }} | ||
| targetPort: 587 | ||
| protocl: TCP |
eozturk1
approved these changes
Feb 20, 2025
Contributor
eozturk1
left a comment
eozturk1
left a comment
There was a problem hiding this comment.
LGTM assuming you have tested this version and confirmed proxy works!
| @@ -0,0 +1,38 @@ | |||
| name: Docker Image Build for PRs | |||
|
|
|||
| # Run on every push to main + weekly, Sunday @ midnight | |||
K91AYAM
approved these changes
Jun 5, 2025
K91AYAM
approved these changes
Jun 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The stats port
8199is open by default, and it should probably be closed.Media ports are not open by default on the helm chart, fixes that
Changes the service type to an external load balancer type so that a default helm deployment creates an external IP.
Also fixes the docker build pipeline for PRs to only build, and not push