Skip to content

Enable ConstructorInjectionOverFieldInjectionDetector to be configured when using AppComponentFactory#237

Draft
WhosNickDoglio wants to merge 1 commit into
mainfrom
configure-constructor-injection
Draft

Enable ConstructorInjectionOverFieldInjectionDetector to be configured when using AppComponentFactory#237
WhosNickDoglio wants to merge 1 commit into
mainfrom
configure-constructor-injection

Conversation

@WhosNickDoglio

@WhosNickDoglio WhosNickDoglio commented Apr 7, 2024

Copy link
Copy Markdown
Owner

Description

Related Issue

Checklist

  • My code follows the style guidelines of this project (./gradlew lint spotlessCheck)
  • I have performed a self-review of my own code
  • I have commented on my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have checked my code and corrected any misspellings
  • I have mentioned changes in CHANGELOG.md.
  • I have read the CONTRIBUTING document.
  • main
    • Enable ConstructorInjectionOverFieldInjectionDetector to be configured when using AppComponentFactory 👈

@codecov

codecov Bot commented Apr 7, 2024

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 88.23529% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.29%. Comparing base (726af09) to head (6ab6b00).

Files with missing lines Patch % Lines
.../ConstructorInjectionOverFieldInjectionDetector.kt 88.23% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #237      +/-   ##
==========================================
- Coverage   90.53%   90.29%   -0.24%     
==========================================
  Files          15       15              
  Lines         528      536       +8     
  Branches       55       58       +3     
==========================================
+ Hits          478      484       +6     
  Misses         34       34              
- Partials       16       18       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@WhosNickDoglio
WhosNickDoglio force-pushed the configure-constructor-injection branch 2 times, most recently from 4c1efe8 to 6c96c04 Compare April 20, 2024 13:13
@WhosNickDoglio
WhosNickDoglio force-pushed the configure-constructor-injection branch from 6c96c04 to b89d788 Compare April 27, 2024 19:58
@WhosNickDoglio
WhosNickDoglio force-pushed the configure-constructor-injection branch 2 times, most recently from ee9a56f to e444f79 Compare June 1, 2024 03:28
@WhosNickDoglio
WhosNickDoglio force-pushed the configure-constructor-injection branch 2 times, most recently from 86c1621 to f7b7819 Compare June 14, 2024 01:52
@WhosNickDoglio
WhosNickDoglio force-pushed the configure-constructor-injection branch 3 times, most recently from 5117451 to 566b17b Compare July 13, 2024 14:31
@WhosNickDoglio
WhosNickDoglio force-pushed the configure-constructor-injection branch from 566b17b to a7f8933 Compare July 28, 2024 12:45
@WhosNickDoglio
WhosNickDoglio force-pushed the configure-constructor-injection branch from a7f8933 to e9e46a8 Compare August 25, 2024 15:57
@WhosNickDoglio
WhosNickDoglio force-pushed the configure-constructor-injection branch 3 times, most recently from f999ba7 to 63948bf Compare September 13, 2024 23:57
@WhosNickDoglio
WhosNickDoglio force-pushed the configure-constructor-injection branch from 63948bf to 3ad7bec Compare October 19, 2024 02:58
@WhosNickDoglio
WhosNickDoglio force-pushed the configure-constructor-injection branch 2 times, most recently from f4b9e72 to b02ae87 Compare November 2, 2024 16:30
@github-actions

github-actions Bot commented Nov 2, 2024

Copy link
Copy Markdown
Contributor
Warnings
⚠️

Any major changes should be added to our CHANGELOG.md file
Changelog format is based on Keep a Changelog.

Generated by 🚫 Danger Kotlin against 6ab6b00

@WhosNickDoglio
WhosNickDoglio force-pushed the configure-constructor-injection branch from b02ae87 to 9138d11 Compare November 16, 2024 20:58
@WhosNickDoglio
WhosNickDoglio force-pushed the configure-constructor-injection branch 2 times, most recently from f578053 to 9138d11 Compare January 10, 2025 17:51
@WhosNickDoglio
WhosNickDoglio force-pushed the configure-constructor-injection branch 2 times, most recently from 6356420 to 9138d11 Compare January 31, 2025 15:56
@WhosNickDoglio
WhosNickDoglio force-pushed the configure-constructor-injection branch from 9138d11 to c73d7f7 Compare May 2, 2026 18:51
@WhosNickDoglio
WhosNickDoglio force-pushed the configure-constructor-injection branch from c73d7f7 to 6ab6b00 Compare May 17, 2026 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant