Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change $TAG to $DIR in execute-gcc-tests.sh and create-gcc-summary.sh so it is easier to use them standalone #186

Merged
merged 1 commit into from
Sep 4, 2024

Conversation

Blackhex
Copy link
Member

@Blackhex Blackhex commented Sep 2, 2024

@Blackhex Blackhex requested a review from eukarpov September 2, 2024 09:05
@Blackhex Blackhex changed the title Change $TAG to $DIR in execute-gcc-tests.sh and create-gcc-summary.sh so it is easier to use them standalone Change $TAG to $DIR in execute-gcc-tests.sh and create-gcc-summary.sh so it is easier to use them standalone Sep 2, 2024
@Blackhex Blackhex requested a review from vejbomar September 2, 2024 09:05
.github/workflows/build-and-test-toolchain.yml Outdated Show resolved Hide resolved
@Blackhex Blackhex changed the base branch from main to absolute-path September 3, 2024 09:44
@Blackhex Blackhex requested a review from eukarpov September 3, 2024 09:47
@Blackhex
Copy link
Member Author

Blackhex commented Sep 3, 2024

@vejbomar
Copy link
Member

vejbomar commented Sep 3, 2024

Can you do the same refactor also for .github/scripts/toolchain/group-gcc-test-failures.sh to keep them unified?

@Blackhex
Copy link
Member Author

Blackhex commented Sep 3, 2024

Can you do the same refactor also for .github/scripts/toolchain/group-gcc-test-failures.sh to keep them unified?

Good point, thank you for noticing.

@Blackhex Blackhex force-pushed the fix-create-summary branch 2 times, most recently from da0dc94 to 8486f89 Compare September 3, 2024 10:13
@vejbomar
Copy link
Member

vejbomar commented Sep 3, 2024

Beside one more question about find this looks good to me. Thanks for simplifying summary steps into one, that is a lot easier to understand now imo since all steps stay in WSL bash instead of switching to powershell

Base automatically changed from absolute-path to main September 3, 2024 11:30
@Blackhex Blackhex force-pushed the fix-create-summary branch 2 times, most recently from ad2654f to ec34bc8 Compare September 3, 2024 14:52
…mary.sh` so it is easier to use them standalone
@Blackhex Blackhex merged commit b5edb17 into main Sep 4, 2024
21 checks passed
@Blackhex Blackhex deleted the fix-create-summary branch September 4, 2024 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants