Audible iframe option#3
Open
iconoclasthero wants to merge 2 commits into
Open
Conversation
… iframe Audible view For match view: Adds option for defaulting audible opening for potential expansion to control panel. Toggles opening style with control/cmd click. Helpers could be expanded for e.g., goodreads
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a flag to control default setting for opening the Audible link from the match screen either in a new tab or in an iframe within the ABS window. Control || Cmd Click inverts the default.
A simple close message is at the top of the iframe audible display. A frame that sat inside the ABS top and left borders would probably look better, but as pointed out, the UI may be changing soon so pouring a lot of time into getting that to work just exactly perfectly would probably be for not in the long run.
This could be expanded to the helper buttons for goodreads and audible in the item view.