Skip to content

fix(pre-commit-hook): same UnicodeDecodeError encoding bug as ownership_engine.py #217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Wolfvin merged 1 commit into from
Jul 12, 2026
Merged

fix(pre-commit-hook): same UnicodeDecodeError encoding bug as ownership_engine.py #217

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions scripts/pre_commit_hook.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,12 @@
import subprocess
import json

# subprocess.run(..., text=True) below also passes encoding='utf-8',
# errors='replace' — without it, Windows decodes with cp1252 (platform
# default) and crashes on git/codelens output containing non-cp1252 bytes
# (accented file/author names, non-ASCII findings text). Same class of bug
# fixed in ownership_engine.py (PR #216).

# Add scripts directory to path
SCRIPT_DIR = os.path.join(os.path.dirname(os.path.abspath(__file__)), '..', '..', 'scripts')
CODELENS = os.path.join(SCRIPT_DIR, 'codelens.py')
Expand All @@ -33,7 +39,8 @@ def main():
try:
result = subprocess.run(
['git', 'diff', '--cached', '--name-only', '--diff-filter=ACMR'],
capture_output=True, text=True, cwd=workspace
capture_output=True, text=True, encoding='utf-8', errors='replace',
cwd=workspace
)
staged_files = [f.strip() for f in result.stdout.strip().split('\n') if f.strip()]
except Exception:
Expand Down Expand Up @@ -67,7 +74,10 @@ def main():
'--max-findings', str(max_findings),
'--commands'] + commands

result = subprocess.run(cmd, capture_output=True, text=True, cwd=workspace, timeout=120)
result = subprocess.run(
cmd, capture_output=True, text=True, encoding='utf-8', errors='replace',
cwd=workspace, timeout=120
)

if result.returncode != 0:
# Gate failed
Expand Down
Loading