Skip to content

fix(security): vuln-scan false positive from declared semver range vs resolved version #229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Wolfvin merged 1 commit into from
Jul 12, 2026
Merged

fix(security): vuln-scan false positive from declared semver range vs resolved version #229

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 12 additions & 8 deletions scripts/vulnscan_engine.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3471,14 +3471,18 @@ def _parse_bun_lock(content: str) -> List[Tuple[str, str]]:
except json.JSONDecodeError:
return packages

# Extract from workspaces dependencies (top-level declared deps)
workspaces = data.get("workspaces", {})
for ws_name, ws_data in workspaces.items():
for dep_type in ("dependencies", "devDependencies"):
deps = ws_data.get(dep_type, {})
for name, version in deps.items():
if name and version:
packages.append((name, version))
# Note: workspaces.dependencies/devDependencies are declared semver RANGES
# from package.json (e.g. "^9.0.0", "~1.2.0") — not concrete installed
# versions. They must NOT be checked directly against vulnerable_range:
# _is_version_vulnerable()/_compare_versions() parse a leading "^"/"~" as
# a non-digit, silently truncating "^9.0.0" to [0,0,0] and making the
# package match ANY "<X.Y.Z" vulnerability range, regardless of the real
# installed version. Found via real-codebase validation: jsonwebtoken
# "installed_version": "^9.0.0" (the declared range) was flagged against
# "vulnerable_range": "<9.0.0" — 9.0.0 is not less than 9.0.0, so this was
# a false positive purely from checking the range string instead of the
# resolved version. Only the "packages" section below (resolved installs)
# has concrete versions suitable for vulnerability matching.

# Extract from packages (resolved packages with exact versions)
# Format: "pkg-name": ["pkg-name@version", "", {...}, "hash"]
Expand Down
Loading