Skip to content

fix(tests): test_doctor.py MagicMock auto-vivifies args.check, breaks 11 tests #232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Wolfvin merged 1 commit into from
Jul 12, 2026
Merged

fix(tests): test_doctor.py MagicMock auto-vivifies args.check, breaks 11 tests #232

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions tests/test_doctor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,15 @@ def _run_doctor(workspace=None, fix=False, verbose=False, fmt="json"):
args.verbose = verbose
args.format = fmt
args.workspace = workspace
# Issue #195 added a --check dispatch to doctor.execute(): when
# getattr(args, "check", None) is truthy, execution goes through
# _dispatch_subcommands() instead of the normal full-checks path.
# MagicMock auto-vivifies any attribute access (args.check returns a
# fresh MagicMock, not None), so without this explicit assignment every
# test using this helper silently exercised the wrong code path and got
# the umbrella {s, st, r} shape instead of doctor's own
# {status, exit_code, checks, ...} shape.
args.check = None
return doctor_module.execute(args, workspace or "")


Expand Down Expand Up @@ -346,6 +355,7 @@ def test_fix_calls_pip_when_deps_missing(self, tmp_path):
args.verbose = False
args.format = "json"
args.workspace = str(tmp_path)
args.check = None # see _run_doctor() docstring
result = doctor_module.execute(args, str(tmp_path))

assert mock_run.called
Expand All @@ -372,6 +382,7 @@ def test_fix_noop_when_nothing_fixable(self, tmp_path):
args.verbose = False
args.format = "json"
args.workspace = str(tmp_path)
args.check = None # see _run_doctor() docstring
result = doctor_module.execute(args, str(tmp_path))

# pip should NOT have been called.
Expand Down
Loading