fix(test): normalize path separator in graph_edges query (closes #268) - #269
Merged
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mengapa
2 test di
test_issue231_async_handler_edges.pygagal di Windows (lolos di Linux CI):_query_graph_edgesexact-matchtarget_id = ?dengan id daribackend.json(Windows: backslashsrc\services\google.ts:2), tapi graph_edges simpan forward slash → 0 hasil. Ditemukan saat verifikasi lokal BOS. Fix #231 sendiri benar (edge terbukti ada).Perbaikan
Normalize separator kedua sisi:
REPLACE(target_id,'\','/') = ?+ param.replace('\','/'). Test-only, tidak sentuh product code.Verifikasi
pytest test_issue231_async_handler_edges.py→ 16 passed di Windows (sebelumnya 14 passed 2 failed). Tetap lolos di Linux (forward slash both sides).Closes #268