fix(output): expose all 11 --format choices + schema_version in json (refs #271 Group A) - #283
Merged
Merged
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
… json (refs #271) Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mengapa (subset #271 — Group A: output-contract drift)
Dua kegagalan test ter-unmask segfault fix, keduanya bug output-contract nyata (repro Windows+Linux):
test_formatters_phase2::test_help_lists_new_formats— argparse--format choicescuma expose 6, padahal 5 formatter Phase-2 (text/junit-xml/emacs/vim/gitlab-sast) ada & berfungsi.test_confidence::TestEndToEndSchemaVersion(×3) — output json default hilangschema_version(drift refactor refactor(commands): consolidate 78 commands → 12 focused commands #195).Perbaikan
_FORMAT_CHOICEStuple = single source of truth semua argparse choices + pre-parse guard.formatters/__init__.pydefault-json stampschema_version(shallow copy, tak mutate caller).secrets→security(umbrella) — bukan pelemahan, tetap assert 5 format muncul.Verifikasi (BOS independen di worktree agent)
test_formatters_phase2.py+test_confidence.py→ 96 passed. 5 format baru hasilkan output; json kini punyaschema_version.Menutup subset Group A #271, bukan seluruh #271. Dikerjakan sub-agent (mati mid-stream sebelum commit); diselamatkan + diverifikasi ulang BOS.