test(cli): fix doubled scripts path in check-positional test (refs #271 Group D) - #287
Merged
Merged
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
…(refs #271) Used relative 'scripts/codelens.py' + PYTHONPATH='scripts'; under CI's cd-scripts cwd that became scripts/scripts/codelens.py → empty output → assertion failed. Use SCRIPT_DIR (absolute), matching sibling tests. Confirms the 'check' command itself is fine — it was a test path-construction bug. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Root cause:
test_check_full_cli_invocation_with_positionalinvoked"scripts/codelens.py"+PYTHONPATH="scripts"(relative) — under CI'scd scripts && pytestcwd that resolved toscripts/scripts/codelens.py(file not found) → empty stdout →assert startswith('{')failed. Fixed toos.path.join(SCRIPT_DIR, "codelens.py")+PYTHONPATH=SCRIPT_DIR, matching sibling tests. Confirms thecheckcommand works — it was purely a test path-construction bug (verified: 1 passed). Test-only, closes another #271 Group D item.