feat(impact): flow-diff — did a named flow's shape change (closes #313)#314
Merged
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
impact --check flow-diff --name X reports the call-edges added/removed WITHIN one named flow between two snapshots — turning edge-diff #297's "200 edges changed" into the actionable "the PAYMENT flow's shape changed: checkout->validate removed, checkout->charge added" (validation bypassed). Pure read-only compose of three existing pieces: flow membership from @flow tags (#309), diff_snapshots edge diff (#297), intra-flow filter matching the subgraph semantics (#311). Home is the impact umbrella, which already exposes --name/--snapshot1/--snapshot2; only a _CHECKS entry and a namespace branch are added. Command count stays 12. Membership is read from tags as-of-now; edges from two snapshots — exactly "compare a pre-PR snapshot against the working tree". Intra-flow only (both endpoints members), keeping signal to the flow's own wiring. Verified end-to-end on a real two-snapshot bypass demo; 8 unit tests (intra-flow filter, owner-strip, bypass detected, unchanged, unknown flow, missing name, edge-leaving-flow ignored). Full suite 19 = 19 on main. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #313. Composes #309 (flow membership) + #297 (edge diff) + #311 (intra-flow filter).
Yang dibangun
impact --check flow-diff --name X— edge yang muncul/hilang di dalam satu flow bernama antara dua snapshot. Mengubah "200 edge berubah" (#297, tak actionable) jadi actionable:→ validasi di-bypass. Persis pertanyaan reviewer.
Arsitektur
Compose read-only, nol engine baru:
audit_tags(member) ×diff_snapshots(#297) → saring intra-flow (kedua endpoint anggota, konsisten #311). Rumahimpact(sudah punya--name/--snapshot1/2). Membership dari tag saat ini, edge dari 2 snapshot = "bandingkan snapshot pra-PR vs working tree". Command count 12.Verifikasi (dijalankan)
Konteks
Ini agent-ergonomics (RFC #279): aku bisa tanya "PR ini mengubah bentuk flow pembayaran?" tanpa membaca diff mentah — CodeLens menggantikan pembacaan manual.
🤖 Generated with Claude Code