Skip to content

Commit

Permalink
Update comments to reflect effective asset cache headers in site heal…
Browse files Browse the repository at this point in the history
…th checks
  • Loading branch information
b1ink0 committed Jan 22, 2025
1 parent 2d08732 commit a048e9f
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 5 deletions.
2 changes: 1 addition & 1 deletion plugins/performance-lab/includes/site-health/load.php
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,6 @@
require_once __DIR__ . '/avif-headers/helper.php';
require_once __DIR__ . '/avif-headers/hooks.php';

// Far-Future Headers site health check.
// Effective Asset Cache Headers site health check.
require_once __DIR__ . '/effective-asset-cache-headers/helper.php';
require_once __DIR__ . '/effective-asset-cache-headers/hooks.php';

Check warning on line 37 in plugins/performance-lab/includes/site-health/load.php

View check run for this annotation

Codecov / codecov/patch

plugins/performance-lab/includes/site-health/load.php#L36-L37

Added lines #L36 - L37 were not covered by tests
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ public function setUp(): void {
}

/**
* Test that the far-future headers test is added to the site health tests.
* Test that the effective caching headers test is added to the site health tests.
*
* @covers ::perflab_effective_asset_cache_headers_add_test
*/
Expand All @@ -46,7 +46,7 @@ public function test_perflab_effective_asset_cache_headers_add_test(): void {
}

/**
* Test that the far-future headers test is attached to the site status tests.
* Test that the effective caching headers test is attached to the site status tests.
*
* @covers ::perflab_effective_asset_cache_headers_add_test
*/
Expand All @@ -55,7 +55,7 @@ public function test_perflab_effective_asset_cache_headers_add_test_is_attached_
}

/**
* Test that when all assets have valid far-future headers, the status is "good".
* Test that when all assets have valid effective caching headers, the status is "good".
*
* @covers ::perflab_effective_asset_cache_headers_assets_test
* @covers ::perflab_effective_asset_cache_headers_check_assets
Expand All @@ -76,7 +76,7 @@ public function test_all_assets_valid_effective_cache_headers(): void {
}

/**
* Test that when an asset has no far-future headers but has conditional caching (ETag/Last-Modified), status is 'recommended'.
* Test that when an asset has no effective caching headers but has conditional caching (ETag/Last-Modified), status is 'recommended'.
*
* @covers ::perflab_effective_asset_cache_headers_assets_test
* @covers ::perflab_effective_asset_cache_headers_check_assets
Expand Down

0 comments on commit a048e9f

Please sign in to comment.