fix: Add change notes to visual diff #3599
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Workday/canvas-kit
|
||||||||||||||||||||||||||||||||||||||||
| Project |
Workday/canvas-kit
|
| Branch Review |
mc-fix-visual-diff-guide
|
| Run status |
|
| Run duration | 02m 24s |
| Commit |
|
| Committer | Manuel Carrera |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
1
|
Pending
|
86
|
Skipped
|
0
|
Passing
|
843
|
| View all changes introduced in this branch ↗︎ | |
UI Coverage
19.41%
|
|
|---|---|
|
Untested elements
|
1526
|
|
Tested elements
|
365
|
Accessibility
99.3%
|
|
|---|---|
|
Failed rules
|
6 critical
5 serious
0 moderate
2 minor
|
|
Failed elements
|
77
|
RayRedGoose
reviewed
Dec 1, 2025
|
|
||
| > **Note:** The visual changes highlight v14 changes + the use of v3 tokens. | ||
|  |
Contributor
There was a problem hiding this comment.
Do we need images here? Can mcp server process that?
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds descriptive change notes to the Canvas Kit v14.0 visual changes documentation and updates the MCP server configuration to include the visual diff document as a resource.
Key Changes:
- Added detailed change descriptions for each component's visual updates in v14
- Updated MCP server config to include the visual changes document
- Created a plain markdown version of the visual changes guide for LLM consumption
Reviewed changes
Copilot reviewed 3 out of 21 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| modules/mcp/lib/config.json | Added visual changes document to MCP server resources list |
| modules/docs/mdx/14.0-VISUAL-CHANGES.mdx | Added comprehensive change notes for all component visual updates |
| modules/docs/llm/upgrade-guides/14.0-VISUAL-CHANGES.md | Created LLM-friendly markdown version with detailed change descriptions |
| modules/docs/llm/upgrade-guides/images/*.png | Added visual comparison images for v14 component changes |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| # Canvas Kit 14.0 and Tokens v3.0 Visual Changes | ||
|
|
||
| This guide contains an overview of the changes in Canvas Kit v14. If you have any issues, feel free | ||
| to report them [here](https://github.com/Workday/canvas-kit/issues). For a mode detailed overview of |
There was a problem hiding this comment.
Spelling error: "mode" should be "more". The text currently reads "For a mode detailed overview" but should read "For a more detailed overview".
Suggested change
| to report them [here](https://github.com/Workday/canvas-kit/issues). For a mode detailed overview of | |
| to report them [here](https://github.com/Workday/canvas-kit/issues). For a more detailed overview of |
|
|
||
| <Graphic src={{url: tertiaryButtonImage}} /> | ||
| - The border radius on Tertiary Buttons is now rounded. | ||
| - The underline has been removed on the default state. Hoever and active still show the underline. |
There was a problem hiding this comment.
Spelling error: "Hoever" should be "Hover". The text currently reads "Hoever and active still show the underline" but should read "Hover and active still show the underline".
Suggested change
| - The underline has been removed on the default state. Hoever and active still show the underline. | |
| - The underline has been removed on the default state. Hover and active still show the underline. |
Comment on lines
+80
to
+90
| - The border radius on inputs is now 6px vs 4px in v13.. | ||
| - This is a component and token level change. | ||
|
|
||
| <Graphic src={{url: textAreaImage}} /> | ||
| - Error and Alert states now have either a light red or light amber background. | ||
| - The border radius on inputs is now 6px vs 4px in v13.. | ||
| - This is a component and token level change. | ||
|
|
||
| <Graphic src={{url: textInputImage}} /> | ||
| - Error and Alert states now have either a light red or light amber background. | ||
| - The border radius on inputs is now 6px vs 4px in v13.. |
There was a problem hiding this comment.
Extra period: "v13.." has two periods when it should only have one. This appears in multiple places (lines 80, 85, 90).
Suggested change
| - The border radius on inputs is now 6px vs 4px in v13.. | |
| - This is a component and token level change. | |
| <Graphic src={{url: textAreaImage}} /> | |
| - Error and Alert states now have either a light red or light amber background. | |
| - The border radius on inputs is now 6px vs 4px in v13.. | |
| - This is a component and token level change. | |
| <Graphic src={{url: textInputImage}} /> | |
| - Error and Alert states now have either a light red or light amber background. | |
| - The border radius on inputs is now 6px vs 4px in v13.. | |
| - The border radius on inputs is now 6px vs 4px in v13. | |
| - This is a component and token level change. | |
| <Graphic src={{url: textAreaImage}} /> | |
| - Error and Alert states now have either a light red or light amber background. | |
| - The border radius on inputs is now 6px vs 4px in v13. | |
| - This is a component and token level change. | |
| <Graphic src={{url: textInputImage}} /> | |
| - Error and Alert states now have either a light red or light amber background. | |
| - The border radius on inputs is now 6px vs 4px in v13. |
Comment on lines
+80
to
+90
| - The border radius on inputs is now 6px vs 4px in v13.. | ||
| - This is a component and token level change. | ||
|
|
||
| <Graphic src={{url: textAreaImage}} /> | ||
| - Error and Alert states now have either a light red or light amber background. | ||
| - The border radius on inputs is now 6px vs 4px in v13.. | ||
| - This is a component and token level change. | ||
|
|
||
| <Graphic src={{url: textInputImage}} /> | ||
| - Error and Alert states now have either a light red or light amber background. | ||
| - The border radius on inputs is now 6px vs 4px in v13.. |
There was a problem hiding this comment.
Extra period: "v13.." has two periods when it should only have one.
Suggested change
| - The border radius on inputs is now 6px vs 4px in v13.. | |
| - This is a component and token level change. | |
| <Graphic src={{url: textAreaImage}} /> | |
| - Error and Alert states now have either a light red or light amber background. | |
| - The border radius on inputs is now 6px vs 4px in v13.. | |
| - This is a component and token level change. | |
| <Graphic src={{url: textInputImage}} /> | |
| - Error and Alert states now have either a light red or light amber background. | |
| - The border radius on inputs is now 6px vs 4px in v13.. | |
| - The border radius on inputs is now 6px vs 4px in v13. | |
| - This is a component and token level change. | |
| <Graphic src={{url: textAreaImage}} /> | |
| - Error and Alert states now have either a light red or light amber background. | |
| - The border radius on inputs is now 6px vs 4px in v13. | |
| - This is a component and token level change. | |
| <Graphic src={{url: textInputImage}} /> | |
| - Error and Alert states now have either a light red or light amber background. | |
| - The border radius on inputs is now 6px vs 4px in v13. |
Comment on lines
+80
to
+90
| - The border radius on inputs is now 6px vs 4px in v13.. | ||
| - This is a component and token level change. | ||
|
|
||
| <Graphic src={{url: textAreaImage}} /> | ||
| - Error and Alert states now have either a light red or light amber background. | ||
| - The border radius on inputs is now 6px vs 4px in v13.. | ||
| - This is a component and token level change. | ||
|
|
||
| <Graphic src={{url: textInputImage}} /> | ||
| - Error and Alert states now have either a light red or light amber background. | ||
| - The border radius on inputs is now 6px vs 4px in v13.. |
There was a problem hiding this comment.
Extra period: "v13.." has two periods when it should only have one.
Suggested change
| - The border radius on inputs is now 6px vs 4px in v13.. | |
| - This is a component and token level change. | |
| <Graphic src={{url: textAreaImage}} /> | |
| - Error and Alert states now have either a light red or light amber background. | |
| - The border radius on inputs is now 6px vs 4px in v13.. | |
| - This is a component and token level change. | |
| <Graphic src={{url: textInputImage}} /> | |
| - Error and Alert states now have either a light red or light amber background. | |
| - The border radius on inputs is now 6px vs 4px in v13.. | |
| - The border radius on inputs is now 6px vs 4px in v13. | |
| - This is a component and token level change. | |
| <Graphic src={{url: textAreaImage}} /> | |
| - Error and Alert states now have either a light red or light amber background. | |
| - The border radius on inputs is now 6px vs 4px in v13. | |
| - This is a component and token level change. | |
| <Graphic src={{url: textInputImage}} /> | |
| - Error and Alert states now have either a light red or light amber background. | |
| - The border radius on inputs is now 6px vs 4px in v13. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add change notes to visual diff docs. Also update the MCP server to include the visual diff as part of the resources.
Release Category
Documentation
Checklist
ready for reviewhas been added to PRFor the Reviewer
Where Should the Reviewer Start?
Areas for Feedback? (optional)
Testing Manually
Screenshots or GIFs (if applicable)
Thank You Gif (optional)