Skip to content

Conversation

@mannycarrera4
Copy link
Contributor

@mannycarrera4 mannycarrera4 commented Nov 17, 2025

Summary

Fixes: #3587
Update our button components to use our new size, shape, padding gap and type tokens.

Release Category

Components


Checklist

For the Reviewer

  • PR title is short and descriptive
  • PR summary describes the change (Fixes/Resolves linked correctly)
  • PR Release Notes describes additional information useful to call out in a release message or removed if not applicable
  • Breaking Changes provides useful information to upgrade to this code or removed if not applicable

Where Should the Reviewer Start?

Areas for Feedback? (optional)

  • Code
  • Documentation
  • Testing
  • Codemods

Testing Manually

Screenshots or GIFs (if applicable)

Thank You Gif (optional)

@mannycarrera4 mannycarrera4 moved this to 🏗 In progress in Canvas Kit Nov 19, 2025
@mannycarrera4 mannycarrera4 moved this from 🏗 In progress to 👀 In review in Canvas Kit Nov 19, 2025
@mannycarrera4 mannycarrera4 added the ready for review Code is ready for review label Nov 19, 2025
@mannycarrera4 mannycarrera4 marked this pull request as ready for review November 19, 2025 19:10
@cypress
Copy link

cypress bot commented Nov 19, 2025

Workday/canvas-kit    Run #9804

Run Properties:  status check passed Passed #9804  •  git commit 4b1762b278 ℹ️: Merge e3d518aa6702c8c35adcf97920dedd3515349346 into 715e44744f25eac8f3ceb1bc6ce0...
Project Workday/canvas-kit
Branch Review mc-token-updates-button
Run status status check passed Passed #9804
Run duration 02m 23s
Commit git commit 4b1762b278 ℹ️: Merge e3d518aa6702c8c35adcf97920dedd3515349346 into 715e44744f25eac8f3ceb1bc6ce0...
Committer Manuel Carrera
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 1
Tests that did not run due to a developer annotating a test with .skip  Pending 86
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 843
View all changes introduced in this branch ↗︎
UI Coverage  19.35%
  Untested elements 1532  
  Tested elements 365  
Accessibility  99.31%
  Failed rules  6 critical   5 serious   0 moderate   2 minor
  Failed elements 77  

@mannycarrera4 mannycarrera4 changed the title feat: Update button components to use new space an shape tokens feat: Update button components to use new space and shape tokens Nov 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready for review Code is ready for review v15

Projects

Status: 👀 In review

Development

Successfully merging this pull request may close these issues.

1 participant