Skip to content

Conversation

Florimond
Copy link

@Florimond Florimond commented May 19, 2023

Adds generic binary heap and d-ary heap.
After a quick look into the what's already provided in this project, I didn't find those more basic datastructures. I thought they could be a nice addition to the more advanced ones proposed here.

@aviary3-wk
Copy link

Security Insights

No security relevant content was detected by automated scans.

Action Items

  • Review PR for security impact; comment "security review required" if needed or unsure
  • Verify aviary.yaml coverage of security relevant code

Questions or Comments? Reach out on Slack: #support-infosec.

@Florimond
Copy link
Author

@dustinhiatt-wf Thoughts?

@ryanjackson-wf
Copy link
Collaborator

Thank you for your contribution. I do not work full time on this library but will look at this more carefully in the coming weeks.

Originally wanted to upgrade to 1.25, but test woulds pass anymore.
Upgrading to 1.18 allows us to use generics while preventing any
additional maintenance as all tests still passes.
@Florimond Florimond marked this pull request as draft September 5, 2025 21:29
@Florimond
Copy link
Author

Converted to draft: I'm busy improving various aspects of these implementation, strengthening the tests, improving the documentation. But most importantly, making the heaps thread-safe.

@ryanjackson-wf
Copy link
Collaborator

Converted to draft: I'm busy improving various aspects of these implementation, strengthening the tests, improving the documentation. But most importantly, making the heaps thread-safe.

Thank you. I was going to review this library's approach to thread safety (or coroutine safety as it were), so I am glad that you are also considering it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants