This repository was archived by the owner on Nov 30, 2024. It is now read-only.
Added addon message for SMSG_SPELL_FAILED_OTHER#305
Open
zelazrgn wants to merge 3 commits intoWowLegacyCore:masterfrom
Open
Added addon message for SMSG_SPELL_FAILED_OTHER#305zelazrgn wants to merge 3 commits intoWowLegacyCore:masterfrom
zelazrgn wants to merge 3 commits intoWowLegacyCore:masterfrom
Conversation
SMSG_SPELL_FAILED_OTHER so added a addon message to send alongside
Collaborator
|
We shouldn't have Hermes send custom addon messages. |
Author
|
I added one of these addon messages as a workaround for #250 I don't like the solution for aura refresh as much, it's hooking into SMSG_SPELL_GO but only if it is an AuraSpells and it calls it for each hit target since I don't want to worry about max message length. Does this seem like a potential performance issue? |
Author
|
I'm looking into handling this the proper way using SMSG_SPELL_INTERRUPT_LOG From testing on classic era, castbar addons don't detect players cancelling a cast, only when they are interrupted. Let me know if this is wrong. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ugly solution for #255
Since SPELL_CAST_FAILED is not triggered by SMSG_SPELL_FAILED_OTHER for some reason
Hopefully there is a better way to fix it.
I'm not sure if the ToUnitGUID is correct and I still need to add things like pets