Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Dec 3, 2025

Book identifiers in USFM markers should always be uppercase regardless of input case.

Changes

  • BTTWriterLoader.cs: Apply ToUpperInvariant() to manifest.project.id when setting IDMarker.TextIdentifier and TOC3Marker.BookAbbreviation
  • Tests: Added coverage for lowercase and mixed-case book identifier inputs
// Before
document.Insert(new IDMarker() { TextIdentifier = manifest.project.id });

// After  
document.Insert(new IDMarker() { TextIdentifier = manifest.project.id.ToUpperInvariant() });
Original prompt

I need book identifiers inserted into USFM to always be caps, add tests for that too


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Copilot AI changed the title [WIP] Add uppercase book identifiers to USFM and tests Ensure book identifiers are uppercase in USFM output Dec 3, 2025
Copilot AI requested a review from rbnswartz December 3, 2025 21:38
@rbnswartz rbnswartz marked this pull request as ready for review December 4, 2025 17:06
@rbnswartz rbnswartz merged commit b5ec241 into develop Dec 4, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants