Add stet exhaustive verse list to passages #266
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
linearcombination
commented
Jun 16, 2025
linearcombination
commented
- Add stet exhaustive verse list to passages app with checkbox and frontend test
- Access USFM parser through HTTP endpoint now rather than using subprocess cli calls
- Further componentization of frontend code, especially svg icons so as to reduce reptition.
- Fix bug in bible reference html template
- See git commit logs for other details
This HTTP endpoint replaces the use of subprocesses. It is a little cleaner.
Simplify frontend code. DRY code.
Keep directory for NT Survey Reviewer's Guide asset separate from other assets as it is semantically in a different class in the sense that it is not retrieved dynamically from the cloud and therefore is not a cloned or downloaded resource.
By request of PO. Add checkbox and logic to support it that allows user to add all of STET verses to list of passages in Passages app.
Let's get log info instead
Because there is only English rg resource
Made this change because github CI is failing in a way that seems to indicate a missing en_rg_nt_survey.docx as a possibility even though it succeeds locally. The reason this could be the case is that github CI might not persist assets between runs and perhaps in that environment the asset is not actually being copied into place.
Caching hid this bug locally, but it showed up on github CI
By request of PO
Also do a tiny bit of refactoring and cleanup
Simplifies code
Only show UX feedback for adding when the user has clicked the checkbox on and not off
PurpleGuitar
approved these changes
Jun 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.